Skip to content

Add difficulty to tags #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Add difficulty to tags #26

merged 1 commit into from
Jun 12, 2022

Conversation

xnorpx
Copy link
Contributor

@xnorpx xnorpx commented Jun 11, 2022

Add difficulty to tags, this allows to create filtered decks based on difficulty.

@fspv
Copy link
Owner

fspv commented Jun 12, 2022

Kind of makes sense. Not sure this should belong to tags, but in case there is no better way to filter I would say it is ok.

@fspv fspv merged commit e085968 into fspv:master Jun 12, 2022
@fspv
Copy link
Owner

fspv commented Jun 12, 2022

After digging a little bit I found out that the tests were not working. After reviving them, I realised they're broken by this diff.

To address that I modified code slightly and fixed the tests 1790db6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants